Skip to content

Conversation

@edenduong
Copy link
Owner

Original Pull Request

magento#18967

Description (*)

While editing wishlist item that has configuration, it will not visible selected on configuration page. But after applying this fix it will work.

Fixed Issues (if relevant)

  1. Magento 2.2.6 Default values are not rendering on Wishlist product edit page. magento/magento2#18555: Magento 2.2.6 Default values are not rendering on Wishlist product edit page

Manual testing scenarios (*)

  1. Add any configurable product with configured attributes to wishlist
  2. Now edit the item from wishlist to change the configuration.
  3. On Item configuration page the previously opted option will get selected automatically.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@edenduong edenduong force-pushed the 2.3-develop-PR-port-18967 branch from b351741 to 62b95a3 Compare July 23, 2019 15:02
@edenduong edenduong changed the title [Forwardport] fixed - Magento 2.2.6 Default values are not rendering on Wishlist product edit page [Forwardport] fixed - Default values are not rendering on Wishlist product edit page Jul 23, 2019
@edenduong edenduong closed this Jul 24, 2019
edenduong pushed a commit that referenced this pull request Aug 9, 2019
edenduong pushed a commit that referenced this pull request Aug 10, 2019
edenduong pushed a commit that referenced this pull request Sep 1, 2019
edenduong pushed a commit that referenced this pull request Oct 5, 2019
edenduong pushed a commit that referenced this pull request Oct 14, 2019
edenduong pushed a commit that referenced this pull request Oct 24, 2019
Issue #1: Static content deploy waits 3 sec in single-job mode after finish
Fixed by moving this sleep() into if ($this->isCanBeParalleled()) { ... }

Issue magento#2: Static content deploy has 5 secs delay between checking if worker job finished processing.
It leads up to 5 sec time waste before next job will start.
Improved by decreasing time from 5 sec to 0.5 sec with saving log refresh rate (10*0.5 sec)

On 4 themes and 7 locales these fixes improve time of static content deploy by 10-15 secs
edenduong pushed a commit that referenced this pull request Oct 30, 2019
…ription-input-box-fix

Fix label being cutoff in Newsletter registration
edenduong pushed a commit that referenced this pull request Nov 19, 2019
…rrors

Filter error array by unique values
edenduong pushed a commit that referenced this pull request Nov 21, 2019
update forked repository 2.3 branch
edenduong pushed a commit that referenced this pull request Dec 6, 2019
slavvka pushed a commit that referenced this pull request Jan 9, 2020
swnsma pushed a commit that referenced this pull request Aug 11, 2020
Merge changes from origin repo
edenduong pushed a commit that referenced this pull request Oct 3, 2020
edenduong pushed a commit that referenced this pull request Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants