Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an LWRP and solo friendly #125

Open
wants to merge 77 commits into
base: master
Choose a base branch
from
Open

Conversation

gondoi
Copy link

@gondoi gondoi commented Jun 5, 2013

These changes include updates from @slizadel that make the cookbook friendly to chef-solo runs. This is done by setting the nodes in an attribute array.

It also adds an LWRP for mongodb_user to allow authentication and setting those users.

Slade Cozart and others added 30 commits February 11, 2013 09:22
Make sure to add self to replicaset if not included. Add ports to rs_member_ips.
initiated, and connect to it for config because we don't have a local
config yet. however, still support if our current server is already initialized
Conflicts:
	definitions/mongodb.rb
	libraries/mongodb.rb
chef_environment:#{replicaset.chef_environment}"
)
if Chef::Config[:solo]
rs_nodes = [node]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this correct? I'd have assumed this would use node['mongodb']['replicaset_members'].

@josephholsten
Copy link

this is insanely large, though it looks reasonable. I wonder, could you split up these features into smaller chunks?

Also there's some stuff that's undocumented, use_fqdn, fqdn_interface, replicaset_members.

@gondoi
Copy link
Author

gondoi commented Aug 13, 2013

I am focused on some other things at the moment, but I'll try to find some time to clean this up and split out some PRs. Although some items end up being dependent on others so I would end up needing to wait for some PRs to be pulled in before sending in another, which extends the contribution time even further. We currently work off of my fork simply because it takes so long to get code merged back in. (This is not limited to this cookbook and happens on official opscode cookbooks as well.) We wanted to contribute back and so we threw this out there.

Although, we would love to see this code in the base cookbook, so I'll look at splitting up what I can and documenting better.

Update search to only include nodes with mongodb recipes.
@wolf31o2
Copy link

Any chance on a rebase of this?

@jamesonjlee
Copy link

that's what i said.

@wolf31o2
Copy link

wolf31o2 commented Nov 3, 2014

I am attempting to pull out the replicaset_members code to allow specifying the members via JSON attribute (role, environment, whatever) instead of search. It's not going so well, yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants