Skip to content

don't use logging.basicConfig #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 28, 2023
Merged

don't use logging.basicConfig #47

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bada8b1
replace basicConfig with setLevel and addHandler
kandersolar Aug 20, 2021
6e9fa91
fix typo
kandersolar Aug 20, 2021
79af065
avoid duplicate handlers
kandersolar Aug 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions cdsapi/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,9 +278,14 @@ def __init__(
else:
level = logging.INFO

logging.basicConfig(
level=level, format="%(asctime)s %(levelname)s %(message)s"
)
self.logger.setLevel(level)

# avoid duplicate handlers when creating more than one Client
if not self.logger.handlers:
formatter = logging.Formatter("%(asctime)s %(levelname)s %(message)s")
handler = logging.StreamHandler()
handler.setFormatter(formatter)
self.logger.addHandler(handler)

dotrc = os.environ.get("CDSAPI_RC", os.path.expanduser("~/.cdsapirc"))

Expand Down