Old CDS-ADS fashion constraints #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ecmwf-cobarzan , FYI, the environment.yaml is for conda and pyproject.toml is for pip, that's why we have the repitition. I think you may need to merge main into your branch too as there were some other changes merged last week |
EddyCMWF
approved these changes
Dec 12, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The major contribution is in constraints.py:apply_constraints_in_old_cds_fashion.
The old logic is a bit complicated (especially due to the needs of some CAMS datasets), but it makes sense. If required we can explain it before the merge.
The date range logic is factored it (maybe a bit hardcoded for now).
The OGC version of the date range widget might need to be adjusted (i.e. not sure if correct as it is).