Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include receipts in downloads and refactor of common code #67

Merged
merged 19 commits into from
Nov 30, 2023
Merged

Include receipts in downloads and refactor of common code #67

merged 19 commits into from
Nov 30, 2023

Conversation

EddyCMWF
Copy link
Contributor

@EddyCMWF EddyCMWF commented Nov 7, 2023 •
edited
Loading

This started out to close #59 , but evolved to include a general refactor to reduce duplicated code, i.e.:

  • several adaptors call a common _pre_retrieve method that performs general pre-processing
  • a make_download_object method which handles the receipts and archiving
  • the convert_format method is implemented more generally

@EddyCMWF EddyCMWF linked an issue Nov 7, 2023 that may be closed by this pull request
Request receipts #59
Closed
@EddyCMWF EddyCMWF requested a review from alexamici November 22, 2023 08:35
@EddyCMWF EddyCMWF changed the title 59 request receipts Include receipts in downloads and refactor of common code Nov 22, 2023
JamesVarndell
JamesVarndell reviewed Nov 30, 2023
View reviewed changes
Copy link
Contributor

@JamesVarndell JamesVarndell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - just a couple of minor comments.

cads_adaptors/adaptors/cds.py Outdated Show resolved Hide resolved
cads_adaptors/adaptors/mars.py Outdated Show resolved Hide resolved
@EddyCMWF EddyCMWF merged commit 2cd5782 into main Nov 30, 2023
@EddyCMWF EddyCMWF deleted the 59-request-receipts branch November 30, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesVarndell JamesVarndell JamesVarndell approved these changes

@alexamici alexamici Awaiting requested review from alexamici

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request receipts
2 participants
@EddyCMWF @JamesVarndell