Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mapping to handle configurable date keywords #32

Merged
merged 7 commits into from
Aug 15, 2023
Merged

mapping to handle configurable date keywords #32

merged 7 commits into from
Aug 15, 2023

Conversation

EddyCMWF
Copy link
Contributor

Please see details in #31

@EddyCMWF EddyCMWF linked an issue Aug 14, 2023 that may be closed by this pull request
mapping to handle configurable date keywords #31
Closed
@EddyCMWF EddyCMWF requested a review from JamesVarndell August 14, 2023 13:38
@alexamici
Copy link
Member

@EddyCMWF looks like pre-commit tests do not pass because trivial style fixes are required.

Please issue a make command to fix the code and please install the pre-commit hook in your working dir with pre-commit install.

JamesVarndell
JamesVarndell approved these changes Aug 15, 2023
View reviewed changes
cads_adaptors/mapping.py Show resolved Hide resolved
@EddyCMWF EddyCMWF merged commit 614f9d1 into main Aug 15, 2023
@EddyCMWF EddyCMWF deleted the 31-mapping-to-handle-configurable-date-keywords branch August 15, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesVarndell JamesVarndell JamesVarndell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mapping to handle configurable date keywords
3 participants
@EddyCMWF @alexamici @JamesVarndell