Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10 base multi adaptor clean #28

Merged
merged 15 commits into from
Aug 15, 2023
Merged

10 base multi adaptor clean #28

merged 15 commits into from
Aug 15, 2023

Conversation

EddyCMWF
Copy link
Contributor

See #10 for more details.

The URL adaptor has been refactored so that:

  • The download_format code can be used by other adaptors
  • It is possible to return a list of files, i.e. without archiving. This is useful for the multi-adaptor as otherwise it would require unpacking and repacking. It may also be useful for users that want to access the list of files uncompressed

@EddyCMWF EddyCMWF requested a review from gbiavati August 10, 2023 16:26
Copy link
Contributor

@gbiavati gbiavati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is fine and we should merge asap.
A comment about logging here is going to be useful. Probably after we should implement logging as a tool and update the package.

@EddyCMWF EddyCMWF merged commit 91a3880 into main Aug 15, 2023
@EddyCMWF EddyCMWF deleted the 10-base-multi-adaptor-clean branch August 15, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants