Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weights added to the simple version of the costing algorithm #236

Merged
merged 7 commits into from
Dec 3, 2024
Merged

weights added to the simple version of the costing algorithm #236

merged 7 commits into from
Dec 3, 2024

Conversation

EddyCMWF
Copy link
Contributor

@EddyCMWF EddyCMWF commented Nov 12, 2024 •
edited
Loading

Implementation of the weighted values and keys in the simple version of the costing algorithm

ecmwf-cobarzan
ecmwf-cobarzan requested changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@ecmwf-cobarzan ecmwf-cobarzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the modifications. But please check the possible side effect created by line 215.

cads_adaptors/costing.py Outdated Show resolved Hide resolved
@ecmwf-cobarzan ecmwf-cobarzan self-requested a review December 3, 2024 21:40
ecmwf-cobarzan
ecmwf-cobarzan approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@ecmwf-cobarzan ecmwf-cobarzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All OK, except for some limitations wrt the partial mapping of the weights, but we can live with those for now.

@ecmwf-cobarzan ecmwf-cobarzan merged commit 4c8f1aa into main Dec 3, 2024
9 checks passed
@ecmwf-cobarzan ecmwf-cobarzan deleted the feature/weights-for-number_of_fields branch December 3, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecmwf-cobarzan ecmwf-cobarzan ecmwf-cobarzan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EddyCMWF @ecmwf-cobarzan