Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes and additions #232

Merged
merged 8 commits into from
Oct 24, 2024
Merged

Small fixes and additions #232

merged 8 commits into from
Oct 24, 2024

Conversation

EddyCMWF
Copy link
Contributor

@EddyCMWF EddyCMWF commented Oct 24, 2024

This only effects currently unused code blocks.
There was a bug which means the new code does not handle null scenarios where nothing was foudn to split on.

Copy link
Contributor

@ecmwf-cobarzan ecmwf-cobarzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All OK!

Copy link
Contributor

@ecmwf-cobarzan ecmwf-cobarzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All OK!

@EddyCMWF EddyCMWF merged commit 9d41d2c into main Oct 24, 2024
9 checks passed
@EddyCMWF EddyCMWF deleted the small-fixes-and-additions branch October 24, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants