Feature/costing with mapped requests #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbiavati
approved these changes
Oct 14, 2024
|
Does |
Yes it does, but I made sure that my previous PR raised InvalidRequest at source (i.e. in apply_mapping) so that this PR also raises good errors: |
|
FYI, it is possible that some 500s may be raised, but this will indicate an action for us to catch some errors we have not yet anticipated. |
malmans2
approved these changes
Oct 14, 2024
mcucchi9
approved these changes
Oct 14, 2024
malmans2
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that date ranges are expanded and users can't cheat the costs so easily
MARS time convention is not expanded, so this does not defend against that, but if that is added to the mapping then this will allow that