-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpi: add uart device_path #842
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on raspberry pi 3
the mraa-uart list is listing the uart bus
The change is technically trivial and looks ok to me, but are you sure the path is the same on RasPi 1 & 2, in addition to 3? Quick googling gives me this may be a RasPi 3 thing and on older versions the port was either On the other hand, if it wasn't there at all, it didn't work anyway, so having a wrong one would do no harm. |
Currently there is no device_path registered for UART in Raspberry Pi source. This will hinder the working of UART driver in mraa. So, register the device_path with '/dev/ttyS0' for all the raspberry pi models except Rpi3. For Rpi3 'dev/serial0' is used as most of the raspbian images make this as a symlink to _real_ UART port by default. Tested-on: Raspberry pi 3 model B Signed-off-by: Manivannan Sadhasivam <[email protected]>
96a4ca7
to
51804c2
Compare
@alext-mkrs I assumed that Changed the serial port to |
@kvkdileep Can you do a quick test now? |
@Mani-Sadhasivam spare me some time, i will test it with sensor having uart interface |
@kvkdileep have you had a chance to test this? |
@kvkdileep did this work? |
@kvkdileep, are you still up to checking this one out? That's the last step before merging as everything else looks ok (Travis failure is unrelated to the change contents). |
If this was tested I'm OK to merge! |
Currently there is no device_path registered for UART in Raspberry Pi
source. This will hinder the working of UART driver in mraa.
So, register the device_path with '/dev/serial0' as most of the
raspbian images make this as a soft link to real UART port by
default.
Tested-on: Raspberry pi 3 model B
Signed-off-by: Manivannan Sadhasivam [email protected]