-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add discoverability feature to kuksa.val.v1 API #641
Add discoverability feature to kuksa.val.v1 API #641
Conversation
91bcc29
to
c56e934
Compare
f5cdeea
to
d7499a5
Compare
Err(_error) => { | ||
println!("Error: Invalid Regex"); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Return error to client?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, should not return anything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't actually tested it, but it looks good to me now.
PR that implements the following examples table for discoverability feature.