Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BCD-3-Clause support #631

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Conversation

erikbosch
Copy link
Contributor

@erikbosch erikbosch commented Jul 31, 2023

Fixes #632

@erikbosch erikbosch changed the title Give more license ouput Add BCD-3-Clause support Jul 31, 2023
@@ -117,7 +117,7 @@ def generate_bom(source_path, target_path, dashout):
errors = []
for crate in crates:
try:
print(f"License for {crate['name']}: ", end="")
print(f"License for {crate['name']} {crate['version']}: ", end="")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to get output with version like:

2023-07-31T16:02:41.7150426Z #0 6.859 License for matchit 0.7.1: MIT.txt BSD-3-Clause.txt

Reason is to be able to compare successful/unsuccessful builds and see if the error because of an updated version.

@erikbosch erikbosch marked this pull request as ready for review July 31, 2023 16:18
Copy link
Contributor

@lukasmittag lukasmittag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lukasmittag lukasmittag merged commit 910e955 into eclipse:master Aug 1, 2023
10 checks passed
@erikbosch erikbosch deleted the erik_bom branch September 29, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cargo license check needs to be extended to cover BSD-3-Clause
2 participants