Ref inter dependencies cleanup #4017
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dseurotech
force-pushed
the
ref-inter_dependencies_cleanup
branch
2 times, most recently
from
ff38722
to
e38ea3b
Compare
dseurotech
force-pushed
the
ref-inter_dependencies_cleanup
branch
from
e38ea3b
to
0edb7bc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4017 +/- ##
==========================================
Coverage 16.79% 16.80%
Complexity 22 22
==========================================
Files 2008 2007 -1
Lines 52210 52190 -20
Branches 4399 4395 -4
==========================================
Hits 8770 8770
+ Misses 43044 43022 -22
- Partials 396 398 +2
|
dseurotech
force-pushed
the
ref-inter_dependencies_cleanup
branch
8 times, most recently
from
40b9b0f
to
8b30561
Compare
dseurotech
force-pushed
the
ref-inter_dependencies_cleanup
branch
6 times, most recently
from
6d26658
to
f62ac3e
Compare
dseurotech
force-pushed
the
ref-inter_dependencies_cleanup
branch
2 times, most recently
from
3638490
to
130bb96
Compare
Signed-off-by: dseurotech <[email protected]>
Signed-off-by: dseurotech <[email protected]>
…if activated it failed compilation without any debug information Signed-off-by: dseurotech <[email protected]>
Signed-off-by: dseurotech <[email protected]>
dseurotech
force-pushed
the
ref-inter_dependencies_cleanup
branch
from
130bb96
to
5622379
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to clean up the internal dependencies between kapua modules. In most cases, it just cleans up the pom.xml files from dependencies which are already received transitively via maven (e.g.: if you already depend on the -internal module, it is implicit the dependence from the -api module).
In a few cases data classes have been moved closer to the project that use them -e.g.: IsJobRunningMultipleResponse.java is specific to the job engine and does not need to be in the commons-rest-model module.