Performance optimizations for Multi-Assignments #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Behl <[email protected]>
Signed-off-by: Stefan Behl <[email protected]>
Signed-off-by: Stefan Behl <[email protected]>
* simplified method * Use @ExpectedEvents instead of EventHandlerStubs * removed @param from 'existsByTargetControllerIdAndStatusAndActiveIsTrue' * reverted metadata initialization Signed-off-by: Ahmed Sayed <[email protected]>
Signed-off-by: Stefan Behl <[email protected]>
stefbehl
commented
Jun 24, 2019
...pa/src/test/java/org/eclipse/hawkbit/repository/event/remote/RemoteTenantAwareEventTest.java
Show resolved
Hide resolved
stefbehl
commented
Jun 24, 2019
| } | ||
|
|
||
| @Test | ||
| @Description("Multiple deployments or distribution set to target assignment test. Expected behaviour is that a new deployment " | ||
| + "overides unfinished old one which are canceled as part of the operation.") | ||
| @ExpectEvents({ @Expect(type = TargetCreatedEvent.class, count = 5 + 4), | ||
| @ExpectEvents({@Expect(type = TargetCreatedEvent.class, count = 5 + 4), |
There was a problem hiding this comment.
Double-check if event stubs can really be removed
AmmarBikic
pushed a commit
to bosch-io/hawkbit
that referenced
this pull request
Oct 2, 2020
* Add remote event test for the new MultiActionEvent * Improve test descriptions * Improve sendMultiActionRequestMessages * Moved action filtering to the database query level (#12) * Use @ExpectedEvents instead of EventHandlerStubs * Removed @param from 'existsByTargetControllerIdAndStatusAndActiveIsTrue' * Reverted metadata initialization * Fix hawkBit bot findings Signed-off-by: Stefan Behl <[email protected]> Signed-off-by: Ahmed Sayed <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request delivers a couple of performance improvements for the new Multi-Assignments feature. The improvements are mainly part of the repository layer and try to optimize the database access calls needed for Multi-Assignments (by reducing the DB calls and by using better queries).
Signed-off-by: Stefan Behl [email protected]