moved action filtering to the database query level #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmed Sayed <[email protected]>
|
@stefbehl could you please verify the changes done specially in the tests (semantics point of view)? I removed the events checking with EventHandlerStub and replaced it with |
Signed-off-by: Ahmed Sayed <[email protected]>
stefbehl
reviewed
Jun 7, 2019
| * @return <code>true</code> if one or more active actions for the given | ||
| * controllerId and action status are found | ||
| */ | ||
| boolean existsByTargetControllerIdAndStatusAndActiveIsTrue(@Param("controllerId") String controllerId, |
There was a problem hiding this comment.
I think you can remove the Param annotations as you do not specify a custom query which references the params
stefbehl
suggested changes
Jun 7, 2019
Signed-off-by: Ahmed Sayed <[email protected]>
a-sayyed
commented
Jun 12, 2019
| @@ -1178,73 +1118,6 @@ public DeploymentResult(final Iterable<Target> deployedTs, final Iterable<Target | |||
|
|
|||
| } | |||
|
|
|||
| protected static class EventHandlerStub implements ApplicationListener<TargetAssignDistributionSetEvent> { | |||
There was a problem hiding this comment.
@peerreviewer double check if the eventHandleStub is really not needed (rudimentary).
There was a problem hiding this comment.
@peerreviewer are the timeouts respected with these changes?
a-sayyed
commented
Jun 12, 2019
| final DistributionSet distributionSet2 = testdataFactory.createDistributionSet(UUID.randomUUID().toString()); | ||
| registerTargetAndAssignDistributionSet(distributionSet2.getId(), TargetUpdateStatus.PENDING, | ||
| getDistributionSet().getModules(), controllerId); | ||
| testdataFactory.addSoftwareModuleMetadata(distributionSet2); |
There was a problem hiding this comment.
@peerreviewer double check if the change doesn't change the test behaviour.
a-sayyed
commented
Jun 12, 2019
| @@ -34,7 +34,7 @@ | |||
| @JsonProperty | |||
| private List<DmfArtifact> artifacts; | |||
| @JsonProperty | |||
| private List<DmfMetadata> metadata; | |||
| private List<DmfMetadata> metadata = Collections.emptyList(); | |||
Signed-off-by: Ahmed Sayed <[email protected]>
stefbehl
added a commit
that referenced
this pull request
Jul 19, 2019
* Add remote event test for the new MultiActionEvent * Improve test descriptions * Improve sendMultiActionRequestMessages * Moved action filtering to the database query level (#12) * Use @ExpectedEvents instead of EventHandlerStubs * Removed @param from 'existsByTargetControllerIdAndStatusAndActiveIsTrue' * Reverted metadata initialization * Fix hawkBit bot findings Signed-off-by: Stefan Behl <[email protected]> Signed-off-by: Ahmed Sayed <[email protected]>
AmmarBikic
pushed a commit
that referenced
this pull request
Oct 2, 2020
* Add remote event test for the new MultiActionEvent * Improve test descriptions * Improve sendMultiActionRequestMessages * Moved action filtering to the database query level (#12) * Use @ExpectedEvents instead of EventHandlerStubs * Removed @param from 'existsByTargetControllerIdAndStatusAndActiveIsTrue' * Reverted metadata initialization * Fix hawkBit bot findings Signed-off-by: Stefan Behl <[email protected]> Signed-off-by: Ahmed Sayed <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ahmed Sayed [email protected]