replace tide with axum in rest plugin and remove async_std dependencies#2176
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2176 +/- ##
=======================================
Coverage ? 74.02%
=======================================
Files ? 400
Lines ? 60846
Branches ? 0
=======================================
Hits ? 45039
Misses ? 15807
Partials ? 0 ☔ View full report in Codecov by Sentry. |
evshary
left a comment
There was a problem hiding this comment.
Overall, LGTM except for some questions.
However, since we don't have a comprehensive unit test for the REST plugin, I would suggest asking the PaaS team to give it a try. Perhaps some behavior might change after the migration and refactor.
|
|
||
| [dependencies] | ||
| axum = "=0.8.4" | ||
| axum-core = "=0.5.2" |
There was a problem hiding this comment.
Why do we need to declare axum-core explicitly in 1.75?
Also, CI suggests using something similar to
[package.metadata.cargo-machete]
ignored = ["prost"]
There was a problem hiding this comment.
axum 0.8.5 bumped the MSRV
| let app = Router::new() | ||
| .route( | ||
| "/{*key_expr}", | ||
| get(subscribe_or_query) |
There was a problem hiding this comment.
https://zenoh.io/docs/apis/rest/
There is no POST in the official documentation, and POST to make query or subscribe makes no sense.
|
Regarding the typos CI check, let's deal with it in another PR |
evshary
left a comment
There was a problem hiding this comment.
Thanks for adding the tests. LGTM except for the CI failures.
9174fba to
b908e75
Compare
|
The Btw argument parsing of |
🏷️ Label-Based Checklist
Based on the labels applied to this PR, please complete these additional requirements:
Labels:
enhancement,dependencies✨ Enhancement Requirements
Since this PR enhances existing functionality:
Remember: Enhancements should not introduce new APIs or breaking changes.
📦 Dependency Updates
Since this PR updates dependencies:
Best practice: Keep dependency updates focused and test thoroughly.
Instructions:
- [ ]to- [x])This checklist updates automatically when labels change, but preserves your checked boxes.