Skip to content

Conversation

yellowhatter
Copy link
Contributor

No description provided.

@yellowhatter yellowhatter self-assigned this Sep 2, 2025
@yellowhatter yellowhatter added enhancement Existing things could work better release Part of the next release labels Sep 2, 2025
@YuanYuYuan
Copy link
Contributor

The change looks good to me, except for the choice of LinkedList rather than VecDeque.

Copy link
Contributor

@YuanYuYuan YuanYuYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge once the CI completes.

Copy link

codecov bot commented Sep 3, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.85%. Comparing base (b6cb64a) to head (582b8c5).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
commons/zenoh-shm/src/metadata/descriptor.rs 0.00% 1 Missing ⚠️
commons/zenoh-shm/src/metadata/storage.rs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2116      +/-   ##
==========================================
+ Coverage   70.82%   70.85%   +0.02%     
==========================================
  Files         373      373              
  Lines       63157    63156       -1     
==========================================
+ Hits        44734    44751      +17     
+ Misses      18423    18405      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yellowhatter yellowhatter merged commit 413bc53 into eclipse-zenoh:main Sep 3, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Existing things could work better release Part of the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants