Skip to content

Conversation

yellowhatter
Copy link
Contributor

@yellowhatter yellowhatter commented Aug 29, 2025

  • adds implicit SHM opt: implicitly pack big slices into SHM buffers. This is true for any operation mode incl. Router - so zenohd will be able to distribute network data as SHM locally
  • optimize different transport objects layouts so that transport is getting more cache-friendly (adds ~500k for both SHM and non-SHM compiled binaries)

@yellowhatter yellowhatter requested a review from wyfo August 29, 2025 16:23
@yellowhatter yellowhatter self-assigned this Aug 29, 2025
@yellowhatter yellowhatter added enhancement Existing things could work better new feature Something new is needed release Part of the next release labels Aug 29, 2025
@yellowhatter yellowhatter force-pushed the implicit_shm_optimization branch from 1c5c747 to f5ef668 Compare August 29, 2025 16:25
@yellowhatter
Copy link
Contributor Author

The CI issues are upstream and not related to this PR

@yellowhatter yellowhatter force-pushed the implicit_shm_optimization branch from 78757c1 to 6669d84 Compare September 1, 2025 08:54
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

❌ Patch coverage is 94.33198% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.90%. Comparing base (b1a5745) to head (808460a).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
io/zenoh-transport/src/shm.rs 90.81% 9 Missing ⚠️
io/zenoh-transport/src/multicast/establishment.rs 90.00% 1 Missing ⚠️
io/zenoh-transport/src/shm_context.rs 97.43% 1 Missing ⚠️
io/zenoh-transport/src/unicast/lowlatency/rx.rs 66.66% 1 Missing ⚠️
io/zenoh-transport/src/unicast/manager.rs 92.85% 1 Missing ⚠️
io/zenoh-transport/src/unicast/universal/tx.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2113      +/-   ##
==========================================
+ Coverage   70.78%   70.90%   +0.12%     
==========================================
  Files         372      373       +1     
  Lines       63024    63157     +133     
==========================================
+ Hits        44609    44780     +171     
+ Misses      18415    18377      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fuzzypixelz fuzzypixelz enabled auto-merge (squash) September 3, 2025 14:22
@fuzzypixelz fuzzypixelz merged commit b6cb64a into eclipse-zenoh:main Sep 3, 2025
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Existing things could work better new feature Something new is needed release Part of the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants