Report proper whatami for adminspace entities #2061
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Router and peers were reporting entities from a local session with their own zid and whatami client (as local sessions are considered as clients internally). This was confusing for users, as zids were reported as clients while they were peers or routers.
Downside: The fix prevents to differentiate router subscriptions between
But it's probably better to add new fields or explicit way to differentiate those cases rather than relying on fake whatami trickery.