Skip to content

Conversation

OlivierHecart
Copy link
Contributor

@OlivierHecart OlivierHecart commented Jul 24, 2025

Router and peers were reporting entities from a local session with their own zid and whatami client (as local sessions are considered as clients internally). This was confusing for users, as zids were reported as clients while they were peers or routers.

Downside: The fix prevents to differentiate router subscriptions between

  • Routers that subscribe on behalf of their subsystem
  • Routers that themselves subscribe (plugin for example).
    But it's probably better to add new fields or explicit way to differentiate those cases rather than relying on fake whatami trickery.

@OlivierHecart OlivierHecart added the bug Something isn't working label Jul 24, 2025
Copy link

codecov bot commented Jul 24, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
472 2 470 0
View the top 1 failed test(s) by shortest run time
zenoh-transport::unicast_transport::transport_unicast_quic_only_server
Stack Traces | 85.6s run time
thread 'transport_unicast_quic_only_server' panicked at .../zenoh-transport/tests/unicast_transport.rs:483:5:
called `Result::unwrap()` on an `Err` value: Elapsed(())
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
View the full list of 1 ❄️ flaky tests
zenoh-transport::unicast_transport::transport_unicast_quic_only_mutual_success

Flake rate in main: 5.71% (Passed 33 times, Failed 2 times)

Stack Traces | 85.6s run time
thread 'transport_unicast_quic_only_mutual_success' panicked at .../zenoh-transport/tests/unicast_transport.rs:483:5:
called `Result::unwrap()` on an `Err` value: Elapsed(())
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@fuzzypixelz fuzzypixelz requested a review from Copilot July 24, 2025 12:48
Copilot

This comment was marked as resolved.

@OlivierHecart OlivierHecart merged commit 49e62bf into main Jul 24, 2025
29 of 30 checks passed
@OlivierHecart OlivierHecart deleted the fix/admin_entities_whatami branch July 24, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants