Skip to content

Conversation

alokpr
Copy link
Contributor

@alokpr alokpr commented Jul 24, 2025

We would like to use these enums as hash keys and discovered that they were not marked as Hashable

Copy link

PR missing one of the required labels: {'dependencies', 'enhancement', 'internal', 'new feature', 'bug', 'breaking-change', 'documentation'}

@alokpr
Copy link
Contributor Author

alokpr commented Jul 24, 2025

CC @JEnoch

Copy link

codecov bot commented Jul 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.80%. Comparing base (4499d0b) to head (1533e37).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
commons/zenoh-protocol/src/core/mod.rs 0.00% 1 Missing ⚠️
zenoh/src/api/publisher.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2060      +/-   ##
==========================================
- Coverage   70.89%   70.80%   -0.09%     
==========================================
  Files         368      368              
  Lines       62266    62266              
==========================================
- Hits        44142    44090      -52     
- Misses      18124    18176      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@diogomatsubara diogomatsubara added the enhancement Existing things could work better label Jul 24, 2025
@sashacmc sashacmc enabled auto-merge (squash) July 24, 2025 13:29
@sashacmc sashacmc merged commit fdb167c into eclipse-zenoh:main Jul 24, 2025
32 of 35 checks passed
@alokpr alokpr deleted the congestion-priority-hash branch July 24, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Existing things could work better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants