Skip to content

Conversation

yellowhatter
Copy link
Contributor

No description provided.

@yellowhatter yellowhatter self-assigned this Jun 27, 2025
@yellowhatter yellowhatter added enhancement Existing things could work better release Part of the next release labels Jun 27, 2025
Copy link
Member

@kydos kydos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link

codecov bot commented Jun 27, 2025

Codecov Report

Attention: Patch coverage is 29.91453% with 82 lines in your changes missing coverage. Please review.

Project coverage is 70.91%. Comparing base (ffbe455) to head (1a77fdc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
commons/zenoh-shm/src/api/provider/shm_provider.rs 23.07% 10 Missing ⚠️
commons/zenoh-sync/src/event.rs 28.57% 10 Missing ⚠️
commons/zenoh-shm/src/api/provider/types.rs 0.00% 8 Missing ⚠️
commons/zenoh-protocol/src/core/endpoint.rs 22.22% 7 Missing ⚠️
commons/zenoh-shm/src/api/buffer/zshm.rs 0.00% 6 Missing ⚠️
commons/zenoh-shm/src/api/buffer/zshmmut.rs 0.00% 6 Missing ⚠️
zenoh/src/net/routing/interceptor/downsampling.rs 0.00% 6 Missing ⚠️
zenoh/src/net/routing/interceptor/qos_overwrite.rs 0.00% 6 Missing ⚠️
plugins/zenoh-plugin-trait/src/compatibility.rs 0.00% 5 Missing ⚠️
zenohd/src/main.rs 0.00% 4 Missing ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2023      +/-   ##
==========================================
- Coverage   71.18%   70.91%   -0.28%     
==========================================
  Files         367      367              
  Lines       61866    61897      +31     
==========================================
- Hits        44041    43894     -147     
- Misses      17825    18003     +178     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yellowhatter yellowhatter marked this pull request as ready for review June 27, 2025 17:17
@yellowhatter yellowhatter merged commit 287d5ac into eclipse-zenoh:main Jun 28, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Existing things could work better release Part of the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants