Skip to content

Conversation

wyfo
Copy link
Contributor

@wyfo wyfo commented May 12, 2025

Resolves #1924

Copy link

PR missing one of the required labels: {'dependencies', 'breaking-change', 'new feature', 'enhancement', 'bug', 'internal', 'documentation'}

@wyfo wyfo added the new feature Something new is needed label May 12, 2025
@wyfo wyfo requested a review from JEnoch May 12, 2025 10:23
@wyfo
Copy link
Contributor Author

wyfo commented May 12, 2025

@JEnoch Could you test that it gives the expected outcome? It seems to work on my laptop, but I would like a more expert review. Also, do you think I went too far in the parsing capabilities?

@wyfo
Copy link
Contributor Author

wyfo commented May 12, 2025

Where should this feature be documented? @milyin

@wyfo wyfo requested a review from OlivierHecart May 12, 2025 11:58
@JEnoch
Copy link
Member

JEnoch commented May 13, 2025

Where should this feature be documented?

Currently, the only place where we document such endpoint config is the DEFAULT_CONFIG.json5, on listen and/or connect sections.
Please add a short description here.

Copy link
Member

@JEnoch JEnoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a minimal doc (endpoint examples) in DEFAULT_CONFIG.json5, in a similar way than bind or iface options.

@gstangel
Copy link

❤️

@JEnoch JEnoch merged commit 8f18ee4 into eclipse-zenoh:main May 20, 2025
51 of 62 checks passed
JEnoch added a commit to ZettaScaleLabs/rmw_zenoh that referenced this pull request May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Something new is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration of DiffServ DSCP class
3 participants