Skip to content

Lowlatency async finalize #1894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2025
Merged

Lowlatency async finalize #1894

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
866c391
Async finalize lowlatency transport when triggered from link to avoid…
yellowhatter Apr 8, 2025
47394f5
fix lints
yellowhatter Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions io/zenoh-transport/src/unicast/lowlatency/link.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,11 @@
c_transport.manager.config.zid,
c_transport.config.zid
);
let _ = c_transport.finalize(0).await;

// Spawn a task to avoid a deadlock waiting for this same task
// to finish in the close() joining its handle
// WARN: Must be spawned on RX
zenoh_runtime::ZRuntime::RX.spawn(async move { c_transport.finalize(0).await });

Check warning on line 139 in io/zenoh-transport/src/unicast/lowlatency/link.rs

View check run for this annotation

Codecov / codecov/patch

io/zenoh-transport/src/unicast/lowlatency/link.rs#L139 

Added line #L139 was not covered by tests
}
};
self.tracker.spawn_on(task, &ZRuntime::TX);
Expand Down Expand Up @@ -202,7 +206,11 @@
c_transport.manager.config.zid,
c_transport.config.zid
);
let _ = c_transport.finalize(0).await;

// Spawn a task to avoid a deadlock waiting for this same task
// to finish in the close() joining its handle
// WARN: Must be spawned on RX
zenoh_runtime::ZRuntime::RX.spawn(async move { c_transport.finalize(0).await });

Check warning on line 213 in io/zenoh-transport/src/unicast/lowlatency/link.rs

View check run for this annotation

Codecov / codecov/patch

io/zenoh-transport/src/unicast/lowlatency/link.rs#L213 

Added line #L213 was not covered by tests
}
},
&ZRuntime::RX,
Expand Down