add qos overwrite interceptor #1825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR missing one of the required labels: {'enhancement', 'internal', 'breaking-change', 'bug', 'documentation', 'new feature', 'dependencies'} |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1825 +/- ##
==========================================
+ Coverage 71.06% 71.15% +0.09%
==========================================
Files 360 363 +3
Lines 65135 65947 +812
==========================================
+ Hits 46286 46925 +639
- Misses 18849 19022 +173 ☔ View full report in Codecov by Sentry. |
DenisBiryukov91
force-pushed
the
qos-interceptor
branch
from
17ed685 to
d218135
Compare
|
PR missing one of the required labels: {'new feature', 'internal', 'bug', 'breaking-change', 'documentation', 'dependencies', 'enhancement'} |
oteffahi
suggested changes
Mar 14, 2025
add config validation tests; set flows to [egress, ingress ] if not specified;
oteffahi
reviewed
Mar 14, 2025
oteffahi
reviewed
Mar 14, 2025
Co-authored-by: Oussama Teffahi <[email protected]>
Co-authored-by: Oussama Teffahi <[email protected]>
oteffahi
suggested changes
Mar 14, 2025
oteffahi
approved these changes
Mar 17, 2025
|
This interceptor needs to be updated with the feature added in #1850 |
OlivierHecart
approved these changes
Mar 25, 2025
JEnoch
added a commit
to ZettaScaleLabs/rmw_zenoh
that referenced
this pull request
Apr 3, 2025
JEnoch
added a commit
to ZettaScaleLabs/rmw_zenoh
that referenced
this pull request
Apr 4, 2025
Yadunund
pushed a commit
to ros2/rmw_zenoh
that referenced
this pull request
Apr 4, 2025
…ic (#591) * Bump zenoh-c to ffa4bdd, zenoh-cpp to 868fdad and zenoh to 3f62ebc * Apply same config changes than eclipse-zenoh/zenoh#1825 * Apply same config changes than eclipse-zenoh/zenoh#1850 * For RELIABLE+TRANSIENT_LOCAL topics, enable sample_miss_detection and recovery for end-to-end reliability
mergify bot
pushed a commit
to ros2/rmw_zenoh
that referenced
this pull request
Apr 4, 2025
…ic (#591) * Bump zenoh-c to ffa4bdd, zenoh-cpp to 868fdad and zenoh to 3f62ebc * Apply same config changes than eclipse-zenoh/zenoh#1825 * Apply same config changes than eclipse-zenoh/zenoh#1850 * For RELIABLE+TRANSIENT_LOCAL topics, enable sample_miss_detection and recovery for end-to-end reliability (cherry picked from commit a9ab960)
mergify bot
pushed a commit
to ros2/rmw_zenoh
that referenced
this pull request
Apr 4, 2025
…ic (#591) * Bump zenoh-c to ffa4bdd, zenoh-cpp to 868fdad and zenoh to 3f62ebc * Apply same config changes than eclipse-zenoh/zenoh#1825 * Apply same config changes than eclipse-zenoh/zenoh#1850 * For RELIABLE+TRANSIENT_LOCAL topics, enable sample_miss_detection and recovery for end-to-end reliability (cherry picked from commit a9ab960)
Yadunund
pushed a commit
to ros2/rmw_zenoh
that referenced
this pull request
Apr 5, 2025
…ic (#591) (#593) * Bump zenoh-c to ffa4bdd, zenoh-cpp to 868fdad and zenoh to 3f62ebc * Apply same config changes than eclipse-zenoh/zenoh#1825 * Apply same config changes than eclipse-zenoh/zenoh#1850 * For RELIABLE+TRANSIENT_LOCAL topics, enable sample_miss_detection and recovery for end-to-end reliability (cherry picked from commit a9ab960) Co-authored-by: Julien Enoch <[email protected]>
Yadunund
pushed a commit
to ros2/rmw_zenoh
that referenced
this pull request
Apr 5, 2025
…ic (#591) (#594) * Bump zenoh-c to ffa4bdd, zenoh-cpp to 868fdad and zenoh to 3f62ebc * Apply same config changes than eclipse-zenoh/zenoh#1825 * Apply same config changes than eclipse-zenoh/zenoh#1850 * For RELIABLE+TRANSIENT_LOCAL topics, enable sample_miss_detection and recovery for end-to-end reliability (cherry picked from commit a9ab960) Co-authored-by: Julien Enoch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add qos overwrite interceptor