Skip to content

Conversation

oteffahi
Copy link
Contributor

Adds ACL policy id for consistency with ACL rules/subjects, and with downsampling interceptor.

Copy link

PR missing one of the required labels: {'internal', 'bug', 'documentation', 'new feature', 'breaking-change', 'dependencies', 'enhancement'}

@oteffahi oteffahi changed the title Add ACL policy id Add policy id to ACL config Feb 18, 2025
@oteffahi oteffahi self-assigned this Feb 18, 2025
@oteffahi oteffahi added the enhancement Existing things could work better label Feb 18, 2025
@oteffahi oteffahi requested review from OlivierHecart and gabrik and removed request for OlivierHecart February 18, 2025 17:53
@gabrik
Copy link
Contributor

gabrik commented Feb 19, 2025

@RemiBarthe 👀

Copy link
Contributor

@gabrik gabrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabrik gabrik merged commit 5250e2e into eclipse-zenoh:main Feb 19, 2025
14 checks passed
@gabrik gabrik deleted the acl/policy-id branch February 19, 2025 11:19
JEnoch added a commit to ZettaScaleLabs/rmw_zenoh that referenced this pull request Feb 25, 2025
JEnoch added a commit to ZettaScaleLabs/rmw_zenoh that referenced this pull request Feb 26, 2025
mmusselman-crl pushed a commit to jmonticelli/zenoh that referenced this pull request Apr 30, 2025
* Add optional ACL Policy id

* Update DEFAULT_CONFIG

* Add acl config format tests

* Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Existing things could work better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants