Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed colcon cmd in README.md #87

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jul 13, 2022

@JEnoch
Copy link
Member

JEnoch commented Jul 13, 2022

Thanks for spotting this!

However, as you can see the eclipsefdn/eca check failed, meaning Eclipse didn't manage to verify your ECA signature wrt. your commits' email address.

Before your contribution can be accepted by the project, you need to create and electronically sign the Eclipse Contributor Agreement (ECA) and sign off on the Eclipse Foundation Certificate of Origin.
For more information, please visit: http://wiki.eclipse.org/Development_Resources/Contributing_via_Git

@JEnoch
Copy link
Member

JEnoch commented Jul 22, 2022

Hi @ahcorde,
I understand the ECA signature requiring to create an Eclipse account can be cumbersome.
But for legal reasons it's required before I can merge your PR.

Otherwise, if you agree, I can copy and directly commit your fix on your behalf.

@ahcorde
Copy link
Contributor Author

ahcorde commented Jul 22, 2022

I will do it today ;)

@ahcorde ahcorde force-pushed the ahcorde/fix/readme branch 2 times, most recently from 490b1e3 to 64d2f32 Compare July 22, 2022 08:24
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde
Copy link
Contributor Author

ahcorde commented Jul 22, 2022

@JEnoch It's green!

@JEnoch JEnoch merged commit 0e4601c into eclipse-zenoh:master Jul 22, 2022
@JEnoch
Copy link
Member

JEnoch commented Jul 22, 2022

Thanks! That's merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants