Added support for Participant discovery and additional QoS policies #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dds into zen-64-01-branch
Supports all QoS policies other than binary properties (a non standard QoS policy). Participants are now discovered and details added to the Zenoh admin space.
It was not possible to prevent serde from serializing null values with the #[serde(skip_serializing_if = "Option::is_none")] as bincode is unable to serialize/deserialize such messages. To avoid null QoS values being added to the admin space a filter function was written to remove null values from the serde_json::Value before returning the result of an admin space query.
This reverts commit 197c868.
JEnoch
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the following:
Note that due to a limitation of bincode it was not possible to use the skip_serializing_if feature of serde to skip any QoS values which were None. Instead, to prevent queries to the admin space returning QoS with many null values I implemented a function to strip any null QoS values from the returned serde JSON object.