Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #407 #416

Merged
merged 1 commit into from
Oct 26, 2016
Merged

Fixes #407 #416

merged 1 commit into from
Oct 26, 2016

Conversation

shiv12095
Copy link
Contributor

@shiv12095 shiv12095 commented Oct 3, 2016 •
edited
Loading

Signed-off-by: shiv12095 [email protected]

@shiv12095 shiv12095 changed the title Fixes #407 Fixes https://github.com/eclipse/vorto/issues/407 Oct 3, 2016
@shiv12095 shiv12095 changed the title Fixes https://github.com/eclipse/vorto/issues/407 Fixes #74 Oct 3, 2016
@shiv12095 shiv12095 changed the title Fixes #74 Fixes #407 Oct 3, 2016
@aedelmann
Copy link
Contributor

Hi Shiv, there seems to be a problem with the IP validation. Did you sign-off your commit properly?

@shiv12095
Copy link
Contributor Author

I guess not, I will create another pull request then

@shiv12095 shiv12095 force-pushed the datatype_web_editor branch from b26af2c to 21cb5ce Compare October 24, 2016 19:47
@shiv12095
Fixes eclipse-vorto#407
21c266e 
Signed-off-by: shiv12095 <[email protected]>
@shiv12095 shiv12095 force-pushed the datatype_web_editor branch from 21cb5ce to 21c266e Compare October 25, 2016 03:30
@aedelmann
Copy link
Contributor

Hi Shiv,
thanks for the IP fix.
I noticed that your new ide bundles are not referenced in the editor feature(s). that is taken during installation of the vorto plugins. Could you add that please also?

Thanks!

@shiv12095
Copy link
Contributor Author

Hi Alex,

According to the logs, the pom.xml of devtool cannot find the package datatype.web
I added this package as a part of this pull request.

This issue seems to be similar to the one we encountered in one of our previous builds https://travis-ci.org/eclipse/vorto/builds/163130725

Last time we had this, we first built the bundles

Can you fix the Travis build to first build the bundles and then server/pom.xml. That might resolve the issue

@aedelmann aedelmann merged commit 7084055 into eclipse-vorto:development Oct 26, 2016
@shiv12095 shiv12095 deleted the datatype_web_editor branch June 12, 2017 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shiv12095 @aedelmann