Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #253 - Update DSL Grammar. #357

Conversation

erlemantos
Copy link
Contributor

@MichaelGuenther Here's the branch for this documentation task.

Signed-off-by: Erle Czar Mantos [email protected]

@aedelmann
Copy link
Contributor

Hi @erlemantos
could you please merge these DSL changes with the existing grammar documentation?

@aedelmann
Copy link
Contributor

@MichaelGuenther @erlemantos What is the status of this Pull Request? It seems to be a single MD file but does not yet fit into our current documentation.

@erlemantos
Copy link
Contributor Author

I've already updated the .md files for the DSL appendix. As to the tutorial that I wrote for the DSL updates, I don't know where to put that.

@aedelmann
Copy link
Contributor

@erlemantos @MichaelGuenther
The improvement markdown has to be somewhat merged with the appendix of function block and datatype where each element is described in the table. At the moment the improvement MD is not referenced from anywhere, how can a user find it ?

@MichaelGuenther
Copy link
Contributor

MichaelGuenther commented Aug 5, 2016

@erlemantos, @aedelmann,
I recognize two task:

  • Updating the examples in the Model DSL Reference
    Please provide reasonable examples updated according to the DSL improvements.
  • Updating the semantics in the Model DSL Reference
    Please provide information (sources) I can incorporate.

Regards
Michael

@aedelmann
Copy link
Contributor

@erlemantos
What is the status of adding in the proposals given by Michael?

Erle Czar Mantos and others added 3 commits August 12, 2016 18:54
Signed-off-by: Erle Czar Mantos <[email protected]>
…e updated,

Signed-off-by: Guenther Michael (INST/BSV2-TD) <[email protected]>
@aedelmann aedelmann force-pushed the features/253_Updates_On_DSL_Grammar branch from 88313ce to 1074320 Compare August 12, 2016 10:54
1) Moved entity and enum to datatype appendix
2) Examples that shows the improvements to the DSL
3) An entire new section of datatype appendix (Semantics) that expounds more on the datatype.
4) Modified the function block and datatype syntax to reflect improvements to the DSL

Signed-off-by: Erle Czar Mantos <[email protected]>
@erlemantos
Copy link
Contributor Author

erlemantos commented Aug 12, 2016

Hi @aedelmann , @MichaelGuenther

I just added some commits to fix the two points pointed out on Michael's comment:

  1. Moved entity and enum to datatype appendix, as they should be in datatype.
  2. Examples in the function block semantics that shows the improvements to the DSL
  3. An entire new section of datatype appendix (Semantics) that expounds more on the
    datatype.
  4. Modified the function block and datatype syntax to reflect improvements
    to the DSL

@aedelmann aedelmann merged commit bb96114 into eclipse-vorto:development Aug 13, 2016
@aedelmann aedelmann deleted the features/253_Updates_On_DSL_Grammar branch August 13, 2016 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants