Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2629. #2648

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Fixes #2629. #2648

merged 1 commit into from
Oct 16, 2020

Conversation

kolotu
Copy link
Contributor

@kolotu kolotu commented Oct 16, 2020

Signed-off-by: Kevin Olotu [email protected]

@kolotu
Fixes eclipse-vorto#2629.
95e8b95 
Signed-off-by: Kevin Olotu <[email protected]>
@kolotu kolotu requested a review from a user October 16, 2020 07:52
ghost
ghost reviewed Oct 16, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worth it / feasible to add an integration test to cache, and then verify the cached value is consistent? Asking just in case - not too knowledgeable about the area.

@kolotu
Copy link
Contributor Author

kolotu commented Oct 16, 2020

@mena-bosch having integration test coverage for generators would definitely be nice to have, but since they are running outside of the repository, there is none currently.
Setting this up will be a bigger task, I created a separate task here #2649

@kolotu kolotu merged commit b626525 into eclipse-vorto:development Oct 16, 2020
@kolotu kolotu deleted the 2629_generator_cache_fix branch October 16, 2020 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kolotu