Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open shared model in editor when clicked in repo browser #141

Merged

Conversation

erlemantos
Copy link
Contributor

Open a shared model in the editor when it is clicked from the model repository browser. Closes #91

Signed-off-by: Erle Czar Mantos [email protected]

Erle Czar Mantos added 4 commits April 13, 2016 11:36
Signed-off-by: Erle Czar Mantos <[email protected]>
Signed-off-by: Erle Czar Mantos <[email protected]>
@aedelmann
Copy link
Contributor

Hi Erle,
when the user clicks on the shared model, it will open in the editor window, right? Is this editor window readonly? Because the user should not have an option to edit the previewed file.

Erle Czar Mantos added 2 commits April 14, 2016 10:50
Signed-off-by: Erle Czar Mantos <[email protected]>
@erlemantos
Copy link
Contributor Author

Added some code to make opening the shared model Read-only.

@aedelmann
Copy link
Contributor

I have two minor points:

  1. Can you rename the temporary files to -preview.
  2. Change the option to preview for models by right-click on the model in the table and choose "Preview" menu item

@erlemantos
Copy link
Contributor Author

Now the previewing of the model is done via the context menu (Right click then Preview Model) rather that when you click the model in the repo table.

@aedelmann aedelmann merged commit 2e047c4 into eclipse-vorto:development Apr 19, 2016
@aedelmann aedelmann deleted the bug/issue-91-preview-shared-model branch April 19, 2016 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants