Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In the toolset, A code generator accepts invalid vorto models #300

Closed
aedelmann opened this issue Jun 26, 2016 · 0 comments
Closed

In the toolset, A code generator accepts invalid vorto models #300

aedelmann opened this issue Jun 26, 2016 · 0 comments
Labels
bug Code Generators enhancement
Milestone
0.9.0

Comments

@aedelmann
Copy link
Contributor

aedelmann commented Jun 26, 2016 •
edited
Loading

A user tries to generate an invalid model
Expected: The generation process aborts and should inform the user that the model is invalid.
Actual: The generator is executed which could potentially result in a non-correct output.

Confirmations:

  • Validation Service in the Vorto Core Bundle that is shared among Toolset and Repository
  • When a user invokes a generator for an invalid model in the toolset using the Eclipse Toolset Generators, the console prints out validation error(s) and aborts the generation process.
@aedelmann aedelmann added this to the 0.9.0 M2 milestone Jun 26, 2016
@aedelmann aedelmann changed the title A code generator only accepts valid vorto models In the toolset, A code generator only accepts valid vorto models Jun 27, 2016
@aedelmann aedelmann changed the title In the toolset, A code generator only accepts valid vorto models In the toolset, A code generator accepts invalid vorto models Jul 8, 2016
erlemantos pushed a commit to bosch-io/vorto that referenced this issue Jul 11, 2016
Fixes eclipse-vorto#243. Also fixes eclipse-vorto#300. This incorpora…
f39fa0c 
…tes suggestions by Alex to not make the 'generator menu' disappear but clicking it when an error is present will make it throw out an error in the console.

Signed-off-by: Erle Czar Mantos <[email protected]>
@erlemantos erlemantos mentioned this issue Jul 11, 2016
Merged
aedelmann pushed a commit that referenced this issue Jul 12, 2016
@aedelmann
Fixes #270 and #300 (#335)
a597987 
* Never return a NULL parsing result.

Signed-off-by: Erle Czar Mantos <[email protected]>

* Partial fix to #243.

Signed-off-by: Erle Czar Mantos <[email protected]>

* Partial fix to #243.

Signed-off-by: Erle Czar Mantos <[email protected]>

* Partial fix to #243 - remove commented out codes.

Signed-off-by: Erle Czar Mantos <[email protected]>

* Fixes #243 - Recursive model references causes error during generation

Signed-off-by: Erle Czar Mantos <[email protected]>

* String literals to constants.

Signed-off-by: Erle Czar Mantos <[email protected]>

* Fixes #243. Also fixes #300. This incorporates suggestions by Alex to not make the 'generator menu' disappear but clicking it when an error is present will make it throw out an error in the console.

Signed-off-by: Erle Czar Mantos <[email protected]>
@aedelmann aedelmann modified the milestones: 0.9.0 M1, 0.9.0 Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Code Generators enhancement
Projects
None yet
Milestone
0.9.0
Development

No branches or pull requests
1 participant
@aedelmann