Allow to configure database container with a fixed port #988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies debugging with tools like wireshark. Signed-off-by: Thomas Segismont <[email protected]>
|
@vietj @BillyYccc tell me if you'd like this for Pg and MySQL too. |
|
yes please @tsegismont it's a blessing to have such feature |
This simplifies debugging with tools like wireshark. Signed-off-by: Thomas Segismont <[email protected]>
Signed-off-by: Thomas Segismont <[email protected]>
|
I didn't do it for MySQL because some tests don't pass when the flag is present. Not sure why |
Rattenkrieg
pushed a commit
to Rattenkrieg/vertx-sql-client
that referenced
this pull request
Nov 8, 2021
…x#988) * Allow to configure SQL Server container with a fixed port This simplifies debugging with tools like wireshark. Signed-off-by: Thomas Segismont <[email protected]> * Allow to configure PostgreSQL Server container with a fixed port This simplifies debugging with tools like wireshark. Signed-off-by: Thomas Segismont <[email protected]> * Update documentation Signed-off-by: Thomas Segismont <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies debugging with tools like wireshark.