Custom Row value codec #879
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Billy Yuan <[email protected]>
|
@vietj can you take a look at the new interfaces and examples in this draft PR and give some opinions? |
|
Sure,
I think the codec should be in SPI package and not in API.
I'll do a review of the rest.
can you open an issue for this task that describes it ?
…On Sun, Jan 31, 2021 at 12:50 AM Billy Yuan ***@***.***> wrote:
@vietj <https://github.com/vietj> can you take a look at the new
interfaces and examples in this draft PR and give some opinions?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#879 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABXDCVUUZTQHRFBCVEJNPTS4SLLVANCNFSM4W2YYELQ>
.
|
|
created an issue in #882. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Provide an API for customizing encoding/decoing row values of different data types, this is only a POC work and I only made a small experiment with MySQL yet.
related feature request collections: