New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong inherited javadoc of AsyncFile#exceptionHandler #5432

Merged

tsegismont merged 1 commit into eclipse-vertx:master from julianladisch:AsyncFile-exceptionHandler-javadoc

Jan 6, 2025

Contributor

julianladisch commented Jan 4, 2025

Motivation:

See
https://vertx.io/docs/5.0.0.CR3/apidocs/io/vertx/core/file/AsyncFile.html#exceptionHandler(io.vertx.core.Handler) The inherited javadoc say that it sets the exception handler on the read stream only.

Fix: Mention that is also sets it on the write stream.

Conformance:

You should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines


          Fix wrong inherited javadoc of AsyncFile#exceptionHandler

b50aca3

See
https://vertx.io/docs/5.0.0.CR3/apidocs/io/vertx/core/file/AsyncFile.html#exceptionHandler(io.vertx.core.Handler)
The inherited javadoc say that it sets the exception handler on the read stream only.

Fix: Mention that is also sets it on the write stream.

tsegismont approved these changes

View reviewed changes

Contributor

tsegismont left a comment

LGTM, thank you @julianladisch

tsegismont merged commit 4b44d70 into eclipse-vertx:master

8 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet