Set request context before recording metrics #5356
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5355
Motivation:
This sets the context so that the logic in Quarkus will know that this call is traced via OpenTracing, and then records and exemplar for the metrics.
I've been monkey-patching Keycloak 26 with a changed
Http1xServerConnection#reportResponseComplete()
and it worked for me in in a manual test.I've been looking for other places of
metrics.requestReset()
andmetrics.responseEnd()
and fixing them the same way.Draft PR for now, as I didn't add any tests, and would probably need help writing some if they would be required. Also waiting for a results that the build returns.Conformance:
You should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines