File resolver supports custom jar URL connection #5029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…than 2) and use them
…URL from the base URL and the entry, this allows custom JarFile extensions to provide a valid URL.
…separator regardless of the prefix (.zip,.war,.jar) we used to include, in order to deal with custom JarFile implementations. The jar URL unpacking for support nested directory was also not correctly implemented although working due to the previous way to analyze the list of entries of a jar URL. The proper way to support nested directories is to unpack the nested directory as a resource and then copy it (relocate) to the correct cache path, e.g. unpack jar:file:/path/to/nesting.jar!/xxx-inf/classes and then copy xxx-inf/classes to the root of the cache, so the subsequent lookup for the nested part designates the correct file. This has been implemented in order to support this properly in a way compatible with the list of entries correction.
vietj
force-pushed
the
custom-jar-file-resolver-4.x
branch
from
088baac to
1e56721
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best effort in Vert.x file resolver to support jar file resolution for simple jar file entries without recursion when the URL to resolve provides a custom protocol that provides a valid jar url connection to a jar file. The file resolver unpacking mechanism is changed to get the jar file to unpack from the jar url connection instead of reconstructing the jar URL deduced from the initial URL to resolve (according to what the classloader resolved).
The extraction of the list of jar entries from the URL has been rewritten in a more generic fashion with a relaxed parsing to accommodate URL with a file that use custom conventions which actually seems fine with the jar url documentation.
This provides a best effort support for Spring boot
nestedcustom protocol https://docs.spring.io/spring-boot/docs/current/reference/html/executable-jar.html#appendix.executable-jar.nested-jars