Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable writeHandlers by default #4626

Merged
merged 3 commits into from
Feb 28, 2023
Merged

Disable writeHandlers by default #4626

merged 3 commits into from
Feb 28, 2023

Conversation

tsegismont
Copy link
Contributor

Closes #4625

@tsegismont tsegismont requested review from vietj and pmlopes February 22, 2023 18:02
@tsegismont
Copy link
Contributor Author

If this PR is approved, the doc must be updated, as well as the breaking changes page.

vietj
vietj requested changes Feb 25, 2023
View reviewed changes
Copy link
Member

@vietj vietj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests to ensure that write handler id are null for WebSocket

@tsegismont
Copy link
Contributor Author

@vietj do you mean a test checking that binaryHandlerId and textHandlerId are null by default? Because writeHandlerId is for net sockets.

@vietj
Copy link
Member

vietj commented Feb 27, 2023

I meant any handler I think

@tsegismont tsegismont requested a review from vietj February 28, 2023 10:35
@vietj vietj merged commit 8df126e into eclipse-vertx:master Feb 28, 2023
vietj
vietj reviewed Feb 28, 2023
View reviewed changes
Copy link
Member

@vietj vietj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsegismont
Copy link
Contributor Author

Thanks for merging @vietj , I'll make a follow-up PR for the documentation

@tsegismont tsegismont deleted the issue/4625 branch February 28, 2023 14:01
@vietj
Copy link
Member

vietj commented Feb 28, 2023 via email

@tsegismont
Copy link
Contributor Author

tsegismont commented Feb 28, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vietj vietj vietj requested changes

@pmlopes pmlopes pmlopes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable writeHandler registration for net sockets and websockets by default
3 participants
@tsegismont @vietj @pmlopes