Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix USubscription doc tests #98

Conversation

sophokles73
Copy link
Contributor

The doc tests had not been updated yet to reflect the changes
introduced to the UTransport trait's functions for matching on
source and sink address patterns.

The doc tests had not been updated yet to reflect the changes
introduced to the UTransport trait's functions for matching on
source and sink address patterns.
@sophokles73 sophokles73 added the bug Something isn't working label May 8, 2024
Copy link
Contributor

@PLeVasseur PLeVasseur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sophokles73 -- does that mean the doc tests didn't catch this and fail the build when the UTransport::register_listener() change went in?

@sophokles73 sophokles73 merged commit 04c9518 into eclipse-uprotocol:main May 9, 2024
10 checks passed
@sophokles73
Copy link
Contributor Author

LGTM

@sophokles73 -- does that mean the doc tests didn't catch this and fail the build when the UTransport::register_listener() change went in?

At least not as part of the tests we run in our standard CI build. That is because that standard build does not activate the usubscription feature, but the nightly build does :-)

@AnotherDaniel
Copy link
Contributor

This is interesting insofar as I'd expect the --all-features flag to enable, well, all features?

@sophokles73
Copy link
Contributor Author

This is interesting insofar as I'd expect the --all-features flag to enable, well, all features?

@AnotherDaniel
Doc tests are not (yet) supported in cargo nextest:
nextest-rs/nextest#16

Maybe you can add an extra cargo test --doc step to the corresponding job?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants