Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting CI-Friendly-Versions in tycho-build-extension #611

Closed
laeubi opened this issue Feb 2, 2022 · 1 comment · Fixed by #914
Closed

Support setting CI-Friendly-Versions in tycho-build-extension #611

laeubi opened this issue Feb 2, 2022 · 1 comment · Fixed by #914
Milestone

Comments

@laeubi
Copy link
Member

laeubi commented Feb 2, 2022

As discussed in #603 CI-Friendly-Versions might be of high value for ease building consistent versions.

We should add support for automatically setting the following items:

  • {revision} initialized with what currently is the DefaultBuildTimestampProvider
  • {sha1} initialized with what currently is the JGitBuildTimestampProvider

this could be done in the following way:

  1. We add a new LifeCycleParticipant
  2. We read from a tycho.config file two properties: cifriendly.revision and cifriendly.sha1 if they are true we set the corresponding value in the maven session properties in afterSessionStarts
  3. Everything else stays as is, with the exception that we skip generation of new qualifiers in BuildQualifierMojo if there is already a value
  4. For Tycho 3.x we can try to overhaul the concept of BuildTimestampProvider so it could be used more flexible, e.g. one might want to have cifriendly.revision not true/false but having a hint for a specific provider to lookup in the PlexusContainer (would require changing the BuildTimestampProvider interface) passing config values and so on
@laeubi laeubi modified the milestones: 2.7, 3.0 Feb 2, 2022
@laeubi
Copy link
Member Author

laeubi commented Feb 2, 2022

I have investigated here and thing with current maven this is to cumbersome.
I therefore have opened apache/maven#674 and will postpone this for 3.0 for now.

laeubi added a commit to laeubi/tycho that referenced this issue Apr 24, 2022
tycho-build-extension

Add a first implementation and integration test
laeubi added a commit to laeubi/tycho that referenced this issue Apr 25, 2022
tycho-build-extension

Add a first implementation and integration test
laeubi added a commit to laeubi/tycho that referenced this issue Apr 25, 2022
tycho-build-extension

Add a first implementation and integration test
laeubi added a commit to laeubi/tycho that referenced this issue Apr 26, 2022
tycho-build-extension

Add a first implementation and integration test
laeubi added a commit to laeubi/tycho that referenced this issue May 2, 2022
tycho-build-extension

Add a first implementation and integration test
laeubi added a commit to laeubi/tycho that referenced this issue May 2, 2022
tycho-build-extension

Add a first implementation and integration test
laeubi added a commit to laeubi/tycho that referenced this issue May 2, 2022
tycho-build-extension

Add a first implementation and integration test
laeubi added a commit to laeubi/tycho that referenced this issue May 3, 2022
tycho-build-extension

Add a first implementation and integration test
laeubi added a commit to laeubi/tycho that referenced this issue May 3, 2022
tycho-build-extension

Add a first implementation and integration test
laeubi added a commit that referenced this issue May 3, 2022
tycho-build-extension

Add a first implementation and integration test
@laeubi laeubi closed this as completed May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant