feat: add helm chart #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before merging this PR #18 should be merged |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Phil91
force-pushed
the
feature/helm-charts
branch
from
d08fdcd
to
dabc3da
Compare
src/credentials/SsiCredentialIssuer.Expiry.App/ExpiryCheckService.cs
Dismissed
Show dismissed
Hide dismissed
Phil91
force-pushed
the
feature/helm-charts
branch
from
dabc3da
to
437c195
Compare
Phil91
force-pushed
the
feat/2-issuer-component
branch
from
d5e30ad
to
0e4854a
Compare
Phil91
force-pushed
the
feature/helm-charts
branch
from
437c195
to
ec492b4
Compare
Phil91
force-pushed
the
feature/helm-charts
branch
from
ec492b4
to
ab909cc
Compare
Phil91
force-pushed
the
feat/2-issuer-component
branch
from
0e4854a
to
603c7b4
Compare
3 tasks
evegufy
requested changes
Mar 14, 2024
There was a problem hiding this comment.
could you please remove SsiCredentialIssuer.Expiry.App.app directory? It's removed in #18 but not in this PR
- fix dockerfile for SsiCredentialIssuer.Expiry.App - fix reference to dockerfile - chore: rename image build workflows
Removed |
- fix: remove lint issue - fix: solve templating issues - chore: change setup of cronjobs: remove hooks - chore: change name setup of job resources - chore: add line breaks - chore: move placeholder value into resources - chore: change to unique templates for db subchart - chore: change secret setup - chore: move passwords from db dependency to according section - chore: remove upgrade env file - chore: change centralidp setup - chore: rearrange health checks - chore: rearrange values file - chore: change ingress to trg-5.04 - chore: fix container name and namespace - chore: change image tag retrieval - chore: change version - chore(db-dependency): change image tag to get latest minor updates - chore: set resource limits - chore: update readme files - chore: change credentialexpiry to camelcase
3 tasks
- chore(helm-test): fix image name and tag override at upgrade - chore: fix owasp scan - chore(helm-test and owasp): change set command - chore: re-arrange values file - chore(pre-checks): run only on changes to src/** - docs(CONTRIBUTING.md): update to contribution details - chore: fix db dependency secret name in cronjobs - chore(dependencies-check): align file naming and docs - chore: remove white space
|
evegufy
changed the title
evegufy
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
LGTM now once #18 (review) is solved also the helm test and owasp workflow should run successfully
evegufy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add helm chart for issuer component
Why
To provide a deployment for the issuer component
Issue
N/A
Checklist