-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(user management): fix disable button state when deselect all checkboxes [updated] #923
Merged
evegufy
merged 6 commits into
eclipse-tractusx:release/v2.1.0-RC2
from
saadanzari:fix/disable-deselect-roles-on-update
Jul 15, 2024
Merged
fix(user management): fix disable button state when deselect all checkboxes [updated] #923
evegufy
merged 6 commits into
eclipse-tractusx:release/v2.1.0-RC2
from
saadanzari:fix/disable-deselect-roles-on-update
Jul 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
oyo
approved these changes
Jul 12, 2024
Hi @saadanzari thank you for your contribution! I needed to release the release candidate for the 2.1.0 version, could you please solve conflict in the with the changelog? |
…update # Conflicts: # CHANGELOG.md
evegufy
requested changes
Jul 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comment
evegufy
requested changes
Jul 15, 2024
evegufy
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Users/Admins are able to deselect all roles assigned to them and confirm during role updates.
Users should not be able to confirm the role update after deselecting all roles assigned to them. At least one role should remain selected at all times.
Users should not be able to confirm the role update after deselecting all roles assigned to them. At least one role should remain selected at all times.
Why
Please include an explanation of why this change is necessary as well as relevant motivation and context. List any dependencies that are required for this change.
Issue
#919
Checklist