Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(constants): use consistent camel case for all the pages #895

Merged
merged 8 commits into from
Jul 10, 2024
Merged

fix(constants): use consistent camel case for all the pages #895

merged 8 commits into from
Jul 10, 2024

Conversation

manojava-gk
Copy link
Contributor

@manojava-gk manojava-gk commented Jun 26, 2024 •
edited
Loading

Description

use consistent camel case for all the pages

Why

page paths are not consistent

Issue

#696

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@manojava-gk manojava-gk marked this pull request as ready for review June 27, 2024 08:52
@manojava-gk
Copy link
Contributor Author

@oyo linter checks are failing with updated yarn.lock.

lavanya-bmw
lavanya-bmw approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@lavanya-bmw lavanya-bmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@oyo oyo merged commit 6e674b4 into eclipse-tractusx:main Jul 10, 2024
7 checks passed
@oyo oyo deleted the fix/issues-696-constants branch July 10, 2024 10:09
@typecastcloud typecastcloud mentioned this pull request Sep 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oyo oyo oyo approved these changes

@lavanya-bmw lavanya-bmw lavanya-bmw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manojava-gk @oyo @lavanya-bmw