Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use scroll to top component from shared components #872

Merged
merged 3 commits into from
Jun 12, 2024
Merged

feat: use scroll to top component from shared components #872

merged 3 commits into from
Jun 12, 2024

Conversation

manojava-gk
Copy link
Contributor

@manojava-gk manojava-gk commented Jun 12, 2024 •
edited
Loading

Description

use scroll to top button component from shared components

Why

move scroll to top button to shared components

Issue

#675

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@manojava-gk manojava-gk marked this pull request as ready for review June 12, 2024 07:25
@manojava-gk manojava-gk requested review from oyo and evegufy June 12, 2024 07:25
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@oyo oyo merged commit 27eef32 into eclipse-tractusx:release/v2.1.0-RC1 Jun 12, 2024
8 checks passed
@oyo oyo deleted the fix/issues-675-scrolltop branch June 12, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oyo oyo oyo approved these changes

@evegufy evegufy Awaiting requested review from evegufy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manojava-gk @oyo