Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app marketplace): add more and collapse #805

Merged
merged 6 commits into from
May 29, 2024

Conversation

lavanya-bmw
Copy link
Contributor

@lavanya-bmw lavanya-bmw commented May 17, 2024

Description

Add more and collapse button to category view

Why

To improve the 'more' button functionality to category view in app marketplace

Issue

#688

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

Copy link
Contributor

@manojava-gk manojava-gk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment. Rest looks fine

src/assets/locales/de/main.json Outdated Show resolved Hide resolved
@lavanya-bmw lavanya-bmw requested a review from oyo May 21, 2024 07:48
oyo
oyo previously approved these changes May 21, 2024
evegufy
evegufy previously approved these changes May 22, 2024
@evegufy evegufy marked this pull request as draft May 22, 2024 05:21
@evegufy
Copy link
Contributor

evegufy commented May 22, 2024

@jjeroch Could you please confirm that this PR should merged to 24.05 anymore but to 24.08 according to the milestone on #688?

@jjeroch
Copy link
Contributor

jjeroch commented May 22, 2024

@evegufy & @lavanya-bmw we should add this to 24.08. please. This is not mission critical for 24.05.

@evegufy evegufy changed the base branch from release/v2.0.0-RC8 to dev May 22, 2024 06:56
@evegufy evegufy dismissed stale reviews from oyo and themself May 22, 2024 06:56

The base branch was changed.

@evegufy evegufy added the merge postponed the merge of this PR shall be postponed until all prerequisites are fulfilled label May 22, 2024
@evegufy
Copy link
Contributor

evegufy commented May 22, 2024

Merge to dev once 2.0.0-RC8 was merged dev

Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lavanya-bmw sorry I forgot to merge the PR after R8 for 2.0.0, could you please resolve the conflict?

@evegufy evegufy changed the base branch from dev to main May 28, 2024 14:15
@evegufy evegufy changed the base branch from main to dev May 28, 2024 14:15
@evegufy evegufy marked this pull request as ready for review May 28, 2024 14:15
Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@lavanya-bmw lavanya-bmw requested a review from evegufy May 29, 2024 06:14
@evegufy evegufy merged commit b20d0a2 into eclipse-tractusx:dev May 29, 2024
8 checks passed
@evegufy evegufy deleted the updates/688/category-view branch May 29, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge postponed the merge of this PR shall be postponed until all prerequisites are fulfilled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants