Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(company data): company data section created #731

Merged
merged 34 commits into from
Jun 3, 2024

Conversation

manojava-gk
Copy link
Contributor

@manojava-gk manojava-gk commented Apr 24, 2024

Description

new section created
navigation from user menu
static listing page
static create site and address flow

related change in the portal helm chart: eclipse-tractusx/portal#317

Why

#623

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

@evegufy evegufy changed the base branch from release/v2.0.0-RC3 to release/v2.0.0-RC4 April 24, 2024 08:52
@evegufy evegufy deleted the branch eclipse-tractusx:dev April 26, 2024 09:50
@evegufy evegufy closed this Apr 26, 2024
@evegufy evegufy reopened this Apr 26, 2024
@evegufy evegufy changed the base branch from release/v2.0.0-RC4 to release/v2.0.0-RC5 April 26, 2024 09:54
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't merge to the release branch for 24.5 release, without final confirmation from @jjeroch, the feature might be moved to the 24.8 release

@evegufy evegufy changed the base branch from release/v2.0.0-RC5 to release/v2.0.0-RC6 May 2, 2024 14:52
@manojava-gk manojava-gk marked this pull request as ready for review May 7, 2024 07:08
@jjeroch
Copy link
Contributor

jjeroch commented May 7, 2024

Please don't merge to the release branch for 24.5 release, without final confirmation from @jjeroch, the feature might be moved to the 24.8 release

@manojava-gk & @evegufy right. We move it to 24.08. Planning to do an interim release mid of June

@manojava-gk manojava-gk changed the base branch from release/v2.0.0-RC6 to dev May 7, 2024 08:28
@manojava-gk manojava-gk requested a review from oyo May 10, 2024 10:04
@manojava-gk
Copy link
Contributor Author

@oyo same issue here as well. DEPENDENCY file is empty

@manojava-gk
Copy link
Contributor Author

@manojava-gk
Copy link
Contributor Author

@oyo @evegufy Is this good to merge? do you have any comments?

oyo
oyo previously approved these changes May 15, 2024
@manojava-gk
Copy link
Contributor Author

@evegufy @oyo any comments on this?

Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please resolve the conflicts?

Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides the conflicts, LGTM 👍
Please also update the changelog

Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@manojava-gk manojava-gk requested a review from evegufy May 30, 2024 06:48
@evegufy evegufy merged commit 45f5ffd into eclipse-tractusx:dev Jun 3, 2024
8 checks passed
@evegufy evegufy deleted the feat/issues-623-company-data branch June 3, 2024 12:09
@MaximilianHauer MaximilianHauer added this to the Release 2.2.0 milestone Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

5 participants