Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing fields to form #1151

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

fix: add missing fields to form #1151

wants to merge 5 commits into from

Conversation

JordanGerada3
Copy link
Contributor

Description

  • Added shortName (legal name) to form
  • Added Company identifier to from
  • Added translations EN, DE
  • Removed unused 'BMW AG' hardcoding from transition files

Why

Necessary information that the user should verify before registering was not available in the form.

Issue

#1140

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybidois ybidois Awaiting requested review from ybidois

@typecastcloud typecastcloud Awaiting requested review from typecastcloud

@isaadansari isaadansari Awaiting requested review from isaadansari

@shubhamv-ss shubhamv-ss Awaiting requested review from shubhamv-ss

@saadanzari saadanzari Awaiting requested review from saadanzari

@ss-nikunj ss-nikunj Awaiting requested review from ss-nikunj

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Portal
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JordanGerada3 @saadanzari @ss-nikunj