Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: data disappearing issue on re-clicking active tab/filter in app/service admin board #1100

Conversation

shahmargi12
Copy link
Contributor

@shahmargi12 shahmargi12 commented Sep 11, 2024

Description

  • Removed unnecessary state reset to maintain data visibility.
  • Updated logic to manage the visibility of the "Load more" button accurately.

Why

To fix the issues with data visibility and "Load more" button behaviour.

Issue

1099

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

@shahmargi12 shahmargi12 changed the title fix: data disappears when re-clicking active tab/filter on app/service admin board fix: data disappearing issue on re-clicking active tab/filter in app/service admin board Sep 12, 2024
Copy link
Contributor

@manojava-gk manojava-gk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lftm. Kindly add notes

@shahmargi12
Copy link
Contributor Author

Lftm. Kindly add notes

@manojava-gk Updated the description in CHANGELOG.md file

@MaximilianHauer MaximilianHauer added this to the Release 24.12 milestone Sep 13, 2024
Copy link
Contributor

@manojava-gk manojava-gk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resetting state was intentional, but approving this PR as it is not breaking feature like sort/filter/search

Copy link

sonarcloud bot commented Sep 17, 2024

@oyo oyo merged commit 1b794dd into eclipse-tractusx:main Sep 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

4 participants