Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updated the checkbox label text #1098

Merged
merged 3 commits into from
Sep 17, 2024
Merged

fix: updated the checkbox label text #1098

merged 3 commits into from
Sep 17, 2024

Conversation

charmi-v
Copy link
Contributor

@charmi-v charmi-v commented Sep 11, 2024 •
edited
Loading

Description

DeleteConfirmationOverlay: Updated label text

Why

  • Inconsistent wording during connector deletion in checkbox label

Issue

#1097

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

manojava-gk
manojava-gk approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@manojava-gk manojava-gk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lftm. Kindly add notes

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@charmi-v
Copy link
Contributor Author

Lftm. Kindly add notes

@manojava-gk, the changelogs have been updated.

@MaximilianHauer MaximilianHauer added this to the Release 24.12 milestone Sep 13, 2024
@oyo oyo merged commit c8b03ea into eclipse-tractusx:main Sep 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oyo oyo oyo approved these changes

@manojava-gk manojava-gk manojava-gk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Portal
Status: USER READY
Milestone
Release 24.12
Development

Successfully merging this pull request may close these issues.
4 participants
@charmi-v @oyo @manojava-gk @MaximilianHauer